From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: wcsncpy bug
Date: Mon, 23 May 2011 03:25:47 +0200 [thread overview]
Message-ID: <20110523012547.GH6142@port70.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 102 bytes --]
wcsncpy(d,s,n) did not decrease n while copying the '\0'
so when s[0]=0 and n=1 it wrote 2 zeros to d
[-- Attachment #2: wcsncpy.diff --]
[-- Type: text/x-diff, Size: 337 bytes --]
diff --git a/src/string/wcsncpy.c b/src/string/wcsncpy.c
index 0164208..fbd0631 100644
--- a/src/string/wcsncpy.c
+++ b/src/string/wcsncpy.c
@@ -3,7 +3,7 @@
wchar_t *wcsncpy(wchar_t *d, const wchar_t *s, size_t n)
{
wchar_t *a = d;
- while (n && (*d++ = *s++)) n--;
+ while (n-- && (*d++ = *s++));
wmemset(d, 0, n);
return a;
}
next reply other threads:[~2011-05-23 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 1:25 Szabolcs Nagy [this message]
2011-05-23 1:51 ` Rich Felker
2011-05-23 2:00 ` Rich Felker
2011-05-23 2:16 ` Szabolcs Nagy
2011-05-23 2:10 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523012547.GH6142@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).