Re: Musl git 0d......455eee8 and recent compilers

[Szabolcs Nagy <nsz@port70.net>]

* Igmar Palsenberg <musl@palsenberg.com> [2011-06-06 10:48:08 +0200]:
> I was using Musle as a test for..

musl


> 1) The struct dirent in include/dirent.h uses a 1 byte array for d_name. In reality, it's larger : We allocate more space than the struct. Since muscle requires a C99 compiler anyway, what's keeping use from using d_name[0] or d_name[] ? If a C89 compiler includes dirent.h, we're screwed anyway :). That will probably silence GCC 4.5 and clang, and severely reduce the warnings it gives in similar cases.
> 

what kind of warnings do you get?
char foo[1] gives warning but a flexible array member char foo[] does not?

> 2) The NULL pointer dereference in src/time/__asctime.c won't work with clang : It removes it. I suggest using either __builtin_trap() or an abort(). If you get to that point, you're in trouble anyway.
> 

i guess __builtin_trap is compiler specific
i don't think it's a big deal..
there could be 0/0 as well i guess
i wonder what
 main(){ return *(int*)0; }
or even
 main(){ return ((int(*)())0)(); }
does on clang..

> 3) Clang does't seem to grasp the weak_alias thingy. It need to check if those parts actually are correct
> 

well it uses the alias __attribute__ extension of gcc

> 4) Is there a muscl testsuite somewhere ?
> 

musl

http://git.etalabs.net/cgi-bin/gitweb.cgi