From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Cleanup patches
Date: Mon, 6 Jun 2011 18:09:15 -0400 [thread overview]
Message-ID: <20110606220915.GF191@brightrain.aerifal.cx> (raw)
In-Reply-To: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com>
On Mon, Jun 06, 2011 at 05:40:35PM +0200, Igmar Palsenberg wrote:
> diff --git a/include/dirent.h b/include/dirent.h
> index ca000bd..5496be3 100644
> --- a/include/dirent.h
> +++ b/include/dirent.h
> @@ -18,7 +18,7 @@ struct dirent
> off_t d_off;
> unsigned short d_reclen;
> unsigned char d_type;
> - char d_name[1];
> + char d_name[];
> };
Fixed in a different way that also gives better glibc
abi-compatibility.
> +++ b/src/malloc/malloc.c
> @@ -16,9 +16,9 @@ void *__mremap(void *, size_t, size_t, int, ...);
> int __madvise(void *, size_t, int);
>
> struct chunk {
> - size_t data[1];
> struct chunk *next;
> struct chunk *prev;
> + size_t data[];
> };
This is plain wrong but if needed I can adjust the code to avoid array
bounds issues.
Rich
next prev parent reply other threads:[~2011-06-06 22:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 15:40 Igmar Palsenberg
2011-06-06 17:13 ` Szabolcs Nagy
2011-06-06 17:32 ` Rich Felker
2011-06-06 18:31 ` Szabolcs Nagy
2011-06-06 18:58 ` Rich Felker
2011-06-07 8:44 ` Igmar Palsenberg
2011-06-07 9:06 ` Szabolcs Nagy
2011-06-07 9:08 ` Igmar Palsenberg
2011-06-07 14:51 ` Rich Felker
2011-06-07 15:26 ` Igmar Palsenberg
2011-06-07 15:39 ` Rich Felker
2011-06-07 10:29 ` Igmar Palsenberg
2011-06-06 22:09 ` Rich Felker [this message]
2011-06-06 22:13 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606220915.GF191@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).