From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/42 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Cleanup patches Date: Mon, 6 Jun 2011 18:09:15 -0400 Message-ID: <20110606220915.GF191@brightrain.aerifal.cx> References: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1307398606 16904 80.91.229.12 (6 Jun 2011 22:16:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2011 22:16:46 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-125-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jun 07 00:16:40 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QTi6B-00050j-SS for gllmg-musl@lo.gmane.org; Tue, 07 Jun 2011 00:16:40 +0200 Original-Received: (qmail 5478 invoked by uid 550); 6 Jun 2011 22:16:39 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 5469 invoked from network); 6 Jun 2011 22:16:39 -0000 Content-Disposition: inline In-Reply-To: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:42 Archived-At: On Mon, Jun 06, 2011 at 05:40:35PM +0200, Igmar Palsenberg wrote: > diff --git a/include/dirent.h b/include/dirent.h > index ca000bd..5496be3 100644 > --- a/include/dirent.h > +++ b/include/dirent.h > @@ -18,7 +18,7 @@ struct dirent > off_t d_off; > unsigned short d_reclen; > unsigned char d_type; > - char d_name[1]; > + char d_name[]; > }; Fixed in a different way that also gives better glibc abi-compatibility. > +++ b/src/malloc/malloc.c > @@ -16,9 +16,9 @@ void *__mremap(void *, size_t, size_t, int, ...); > int __madvise(void *, size_t, int); > > struct chunk { > - size_t data[1]; > struct chunk *next; > struct chunk *prev; > + size_t data[]; > }; This is plain wrong but if needed I can adjust the code to avoid array bounds issues. Rich