From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/43 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Cleanup patches Date: Mon, 6 Jun 2011 18:13:50 -0400 Message-ID: <20110606221350.GG191@brightrain.aerifal.cx> References: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1307398878 18328 80.91.229.12 (6 Jun 2011 22:21:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2011 22:21:18 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-126-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jun 07 00:21:15 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QTiAc-0006jE-RG for gllmg-musl@lo.gmane.org; Tue, 07 Jun 2011 00:21:14 +0200 Original-Received: (qmail 7433 invoked by uid 550); 6 Jun 2011 22:21:14 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 7425 invoked from network); 6 Jun 2011 22:21:14 -0000 Content-Disposition: inline In-Reply-To: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:43 Archived-At: On Mon, Jun 06, 2011 at 05:40:35PM +0200, Igmar Palsenberg wrote: > - if ((uintptr_t)base < mal.brk) *(char *)0=0; > + if ((uintptr_t)base < mal.brk) > + raise(SIGSEGV); [etc.] Fixed using (volatile char *)0=0; instead. As per the original commit message for this code, the intent is to provide some added safety and debugging assistance without any significant increase in code size or bloat. Rich