From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: Cleanup patches
Date: Tue, 7 Jun 2011 11:06:09 +0200 [thread overview]
Message-ID: <20110607090609.GB5512@port70.net> (raw)
In-Reply-To: <495DC2BF-B857-4BD5-95B1-753C0DB0DE6A@palsenberg.com>
* Igmar Palsenberg <musl@palsenberg.com> [2011-06-07 10:44:44 +0200]:
> The cast should be OK. In cases where it is correct (and the cast isn't necessary), it is simply a NOOP.
>
a superfluous type cast is not OK even if it's a NOOP
it's ugly, dangerous and surprising
in this case the cast hides an important warning:
wchar_t of musl and the compiler is different
the solution is to define wchar_t properly
it seems pcc and gcc defines __WCHAR_TYPE__
if clang has it defined as well then i guess musl can use it
and fall back to int when it's not defined
next prev parent reply other threads:[~2011-06-07 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 15:40 Igmar Palsenberg
2011-06-06 17:13 ` Szabolcs Nagy
2011-06-06 17:32 ` Rich Felker
2011-06-06 18:31 ` Szabolcs Nagy
2011-06-06 18:58 ` Rich Felker
2011-06-07 8:44 ` Igmar Palsenberg
2011-06-07 9:06 ` Szabolcs Nagy [this message]
2011-06-07 9:08 ` Igmar Palsenberg
2011-06-07 14:51 ` Rich Felker
2011-06-07 15:26 ` Igmar Palsenberg
2011-06-07 15:39 ` Rich Felker
2011-06-07 10:29 ` Igmar Palsenberg
2011-06-06 22:09 ` Rich Felker
2011-06-06 22:13 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607090609.GB5512@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).