From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/45 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: Cleanup patches Date: Tue, 7 Jun 2011 11:06:09 +0200 Message-ID: <20110607090609.GB5512@port70.net> References: <60BABB60-7D9B-4D66-8645-4CDFD07E1338@palsenberg.com> <20110606171317.GN6142@port70.net> <20110606173210.GD191@brightrain.aerifal.cx> <495DC2BF-B857-4BD5-95B1-753C0DB0DE6A@palsenberg.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1307437597 10636 80.91.229.12 (7 Jun 2011 09:06:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Jun 2011 09:06:37 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-128-gllmg-musl=m.gmane.org@lists.openwall.com Tue Jun 07 11:06:33 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QTsF6-0003aC-Ih for gllmg-musl@lo.gmane.org; Tue, 07 Jun 2011 11:06:32 +0200 Original-Received: (qmail 16024 invoked by uid 550); 7 Jun 2011 09:06:32 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 16013 invoked from network); 7 Jun 2011 09:06:31 -0000 Content-Disposition: inline In-Reply-To: <495DC2BF-B857-4BD5-95B1-753C0DB0DE6A@palsenberg.com> User-Agent: Mutt/1.5.20 (2009-06-14) Xref: news.gmane.org gmane.linux.lib.musl.general:45 Archived-At: * Igmar Palsenberg [2011-06-07 10:44:44 +0200]: > The cast should be OK. In cases where it is correct (and the cast isn't necessary), it is simply a NOOP. > a superfluous type cast is not OK even if it's a NOOP it's ugly, dangerous and surprising in this case the cast hides an important warning: wchar_t of musl and the compiler is different the solution is to define wchar_t properly it seems pcc and gcc defines __WCHAR_TYPE__ if clang has it defined as well then i guess musl can use it and fall back to int when it's not defined