From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/56 Path: news.gmane.org!not-for-mail From: Solar Designer Newsgroups: gmane.linux.lib.musl.general Subject: Re: Weekly reports - B Date: Mon, 13 Jun 2011 06:11:30 +0400 Message-ID: <20110613021130.GA21268@openwall.com> References: <4DF12B1D.7050106@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1307931100 7229 80.91.229.12 (13 Jun 2011 02:11:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Jun 2011 02:11:40 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-140-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 13 04:11:36 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QVwcq-0003RD-Kq for gllmg-musl@lo.gmane.org; Mon, 13 Jun 2011 04:11:36 +0200 Original-Received: (qmail 9794 invoked by uid 550); 13 Jun 2011 02:11:35 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 9786 invoked from network); 13 Jun 2011 02:11:35 -0000 Content-Disposition: inline In-Reply-To: <4DF12B1D.7050106@gmail.com> User-Agent: Mutt/1.4.2.3i Xref: news.gmane.org gmane.linux.lib.musl.general:56 Archived-At: Luka, Rich - On Thu, Jun 09, 2011 at 10:20:45PM +0200, Luka Mar??eti?? wrote: > Anyway, here's something... *hangs head* > https://github.com/paxcoder/cluts Thanks for posting this. I took a look. This is good for the start, but we obviously need a lot more. ;-) Sorry to remind you, but we need Luka's code placed under an Open Source license - and not only when cluts is "finished". Each week's update must be properly licensed. Can one or both of you please propose a license you're comfortable with? Some assorted comments on the code, in arbitrary order: For jumping out of a signal handler, you need to use sigjmp_buf, sigsetjmp(), and siglongjmp(). Even so, some failed libc functions might leave stdio (or something else) in an inconsistent state. This is probably irrelevant to simple string functions testing, but it will be relevant to some other tests. Thus, since we don't expect SIGSEGVs to be frequent, maybe it'd be better to switch to forking child processes (which must print something specific to fd 1 to indicate success)? Or we can use both approaches - in different cases, as appropriate. When you declare identifiers at the global scope in a file, but don't need them exported to other source files, please make them "static" to prevent inadvertent use from another source file. What do you mean by "#define _XOPEN_SOURCE 9001"? I think the highest value currently defined is 700, and going too high may actually prevent this from working (e.g., on Solaris). Please avoid assignments to errno. Use your own variable instead. Overall, I think the code could be made prettier. I'll post an idea (which you don't have to use, but you may) in another message. Luka - when I say that something could be written better, etc., please don't be discouraged. On the contrary, this indicates that you're doing something interesting, comment-worthy. :-) I am merely trying to provide constructive criticism and help the project in this way. Thanks again, Alexander