From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/164 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts review Date: Thu, 14 Jul 2011 14:56:01 -0400 Message-ID: <20110714185601.GM16618@brightrain.aerifal.cx> References: <20110713110723.GA22153@openwall.com> <4E1D8964.3020502@gmail.com> <20110713160327.GA24660@openwall.com> <4E1DCDE5.1040008@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1310670331 23855 80.91.229.12 (14 Jul 2011 19:05:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 14 Jul 2011 19:05:31 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-248-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 14 21:05:26 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QhRDx-0001aV-U7 for gllmg-musl@lo.gmane.org; Thu, 14 Jul 2011 21:05:26 +0200 Original-Received: (qmail 7981 invoked by uid 550); 14 Jul 2011 19:05:25 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 7970 invoked from network); 14 Jul 2011 19:05:25 -0000 Content-Disposition: inline In-Reply-To: <4E1DCDE5.1040008@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:164 Archived-At: On Wed, Jul 13, 2011 at 06:55:01PM +0200, Luka Marčetić wrote: > >I got lots of errors from "numeric" - I didn't bother recording most. > >The above are just a few of them. > > In my opinion, the errors are warranted. But I asked Rich for review I'm a bit confused by this one: strtoumax("0xX", &endptr) should return 0, errno=0(Invalid error number) instead, it returns 0, errno=EINVAL Why do you expect it to return with errno=0? Since the subject sequence does not have a correct form, I believe the implementation may (and should, from a quality of implementation standpoint) set errno to EINVAL. Of course a portable application will need to examine endptr instead of errno to check this case. The remaining errors all seem correct. It's expected that glibc fails lots of these tests. See: http://sourceware.org/bugzilla/show_bug.cgi?id=12701 Rich