mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: holywar: malloc() vs. OOM
Date: Sun, 24 Jul 2011 18:19:07 -0400	[thread overview]
Message-ID: <20110724221907.GL132@brightrain.aerifal.cx> (raw)
In-Reply-To: <20110724182533.GB6429@albatros>

On Sun, Jul 24, 2011 at 10:25:33PM +0400, Vasiliy Kulikov wrote:
> Oh, I forgot one major detail - the kernel by default have memory
> overcommit enabled (sysctl vm.overcommit_memory=0).  It means that even
> [...]
> For overcommit disabled OOM graceful handling should be possible, but
> I'm not sure it is _guaranteed_ that memory allocated by brk() and
> mmap() will be really available in the future.

Any system without this guarantee is a TOY, nothing more. I'm aware
that the default sucks, but that's not an excuse to break things for
competent admins who know how to fix the default...

> So, yes, if the program guarantees that it gracefully handle OOM *for
> sure*, then the workaround is indeed a breakage.  But I'm sure such
> programs are hell rare.  BTW, do you know such programs, except DBUS? :)

Pretty much any decent httpd, sshd, database, etc. should handle OOM
just fine - rejecting any connections for which the necessary
allocation fails. Having the daemon crash and not accept further
connections after the OOM condition is over would be very bad
behavior. Of course DJB liked writing software that way and using a
secondary daemon to restart his daemons when they crash, but that's
really unprofessional... and you can certainly come up with
applications where it would be very bad to have to restart when
somebody OOM'd it - a multiplayer game server comes to mind...

> > A better solution might be to have a gcc option to generate a read
> > from the base address the first time a function performs arithmetic on
> > a pointer it has not already checked. This is valid because the C
> > language does not allow pointer arithmetic to cross object boundaries,
> > and this approach could be made 100% correct rather than being a
> > heuristic that breaks correct applications.
> 
> A good idea.  It would be interesting to show actual numbers of the
> slowdown.  However, most of the time it would be a slowdown for no
> actual gain.

Actually it might be a speedup since it would act like a prefetch...
:)

Rich


  reply	other threads:[~2011-07-24 22:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-24 10:33 Vasiliy Kulikov
2011-07-24 12:40 ` Rich Felker
2011-07-24 13:29   ` Szabolcs Nagy
2011-07-24 13:27     ` Rich Felker
2011-07-24 18:33       ` Vasiliy Kulikov
2011-07-24 22:24         ` Rich Felker
2011-07-24 18:25   ` Vasiliy Kulikov
2011-07-24 22:19     ` Rich Felker [this message]
2011-07-25 17:43       ` Vasiliy Kulikov
2011-07-25 19:21         ` Rich Felker
2011-07-24 12:44 ` Szabolcs Nagy
2011-07-24 12:53   ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110724221907.GL132@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).