From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/249 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: BusyBox ? Date: Fri, 5 Aug 2011 13:52:31 -0400 Message-ID: <20110805175231.GD132@brightrain.aerifal.cx> References: <9f8fcd37dea8cd3fe5ce425947229ced@smtp1.ispfr.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1312567496 25551 80.91.229.12 (5 Aug 2011 18:04:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 5 Aug 2011 18:04:56 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-333-gllmg-musl=m.gmane.org@lists.openwall.com Fri Aug 05 20:04:52 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QpOlQ-00070F-Au for gllmg-musl@lo.gmane.org; Fri, 05 Aug 2011 20:04:52 +0200 Original-Received: (qmail 22214 invoked by uid 550); 5 Aug 2011 18:04:51 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 22206 invoked from network); 5 Aug 2011 18:04:51 -0000 Content-Disposition: inline In-Reply-To: <9f8fcd37dea8cd3fe5ce425947229ced@smtp1.ispfr.net> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:249 Archived-At: On Fri, Aug 05, 2011 at 07:41:22PM +0200, nicolas@atelier-web.com wrote: > Thanks ! > > Is this patch always necessary ? > https://github.com/chneukirchen/sabotage/blob/master/KEEP/busybox.patch Many of these issues have since been fixed or at least changed in upstream BusyBox. Hopefully fewer changes are needed now... > If yes, should we contact the BusyBox project to say them to add the : #if > defined(__musl__) ? No, because __musl__ is not defined by musl; it's something added by Sabotage. The right fix is to find out whether it's musl or BusyBox doing things wrong and fix one or the other so that things work without ugly special-casing. Rich