From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/378 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: New daily reports - nothing Date: Wed, 10 Aug 2011 00:59:33 -0400 Message-ID: <20110810045933.GW132@brightrain.aerifal.cx> References: <4E39C84F.8060705@gmail.com> <20110803224651.GB11437@openwall.com> <4E3A79B2.8090204@gmail.com> <4E3B331E.7050502@gmail.com> <4E3CC5AC.3070404@gmail.com> <4E3DFB5D.8040008@gmail.com> <20110807073224.GG132@brightrain.aerifal.cx> <4E3F10C7.4060601@gmail.com> <4E40A33F.7090804@gmail.com> <4E41E020.7020109@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1312953151 19687 80.91.229.12 (10 Aug 2011 05:12:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 10 Aug 2011 05:12:31 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-379-gllmg-musl=m.gmane.org@lists.openwall.com Wed Aug 10 07:12:27 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Qr15f-0002gU-7w for gllmg-musl@lo.gmane.org; Wed, 10 Aug 2011 07:12:27 +0200 Original-Received: (qmail 20158 invoked by uid 550); 10 Aug 2011 05:12:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 20150 invoked from network); 10 Aug 2011 05:12:26 -0000 Content-Disposition: inline In-Reply-To: <4E41E020.7020109@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:378 Archived-At: On Wed, Aug 10, 2011 at 03:34:24AM +0200, Luka Marčetić wrote: > Nothing to report for today, I'm afraid. > Not much time left either. I hoped you'd suggest what to do, but I > had to spend time fixing stuff anyway. And since I still do, my > priorities are: > > - Fix and commit buf.c * > - Fix other tests that are still broken (setuid, alloc) > - Complete the started ones (pthread_eintr) As I see it, what you've got (in varying stages of completeness) is categories 1, 2, 3, 6, 8, and 9, from the project description here: http://openwall.info/wiki/musl/unit-tests Here are the things I would like you to focus on right now, roughly in order of priority: 1. Fixing issues with test validity, like the buffer overflow/heap corruption issues that make it impossible to actually detect failure. This is a must. 2. Documenting the tests you have: what assertions they test. As examples, "memcpy does not read past the end of the source buffer", or "pthread_mutex_lock does not return EINTR when a signal is handled while waiting for the lock". Along with that, a description of what conditions the test covers (since for most of the tests, there's theoretically a near-infinite set of possible inputs, and you can only test a "representative" subset). (I know you already have pretty good comments in the code, but what I'm talking about is higher-level documentation, whether in comments or separate from the source, about the larger purpose of the code and what each test is checking.) 3. Cleaning up the build system and source to make sure it builds without modification (except perhaps CFLAGS tweaks) on fairly recent glibc and musl version. 4. Finish testing additional areas in the categories you're already working on. 5. Test categories 4 and 5. I think it would be nice to pull in some existing third-party (e.g. GNU) tests for these, but clean them up (as in the project description) to avoid checking for GNU-specific stuff and not to bail out as soon as the first test fails. One thing I'd like you to drop for now is working on the setuid test. It's been a time sink, and based on the work and discussion we already did (which were very valuable in themselves), I have a working test for it. You're welcome to incorporate that in cluts (preferably after GSoC). I know this is kinda frustrating, but we really don't have time for you to keep trying to fix it alongside all the other work that remains to be done. Rich