From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/432 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: cluts priorities [was: New daily reports - nothing] Date: Tue, 16 Aug 2011 14:19:28 -0400 Message-ID: <20110816181928.GU132@brightrain.aerifal.cx> References: <20110816154234.GS132@brightrain.aerifal.cx> <4E4AA12E.6000506@gmail.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1313518838 20950 80.91.229.12 (16 Aug 2011 18:20:38 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 16 Aug 2011 18:20:38 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-433-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 16 20:20:29 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1QtOFZ-0008P3-H4 for gllmg-musl@lo.gmane.org; Tue, 16 Aug 2011 20:20:29 +0200 Original-Received: (qmail 28228 invoked by uid 550); 16 Aug 2011 18:20:29 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 28218 invoked from network); 16 Aug 2011 18:20:28 -0000 Content-Disposition: inline In-Reply-To: <4E4AA12E.6000506@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:432 Archived-At: On Tue, Aug 16, 2011 at 06:56:14PM +0200, Luka Marčetić wrote: > On 08/16/2011 05:42 PM, Rich Felker wrote: > >I really need to ask that you to prioritize the work that remains. As > >an example, adding additional EINTR tests falls under number 4 (finish > >testing additional areas...) while 1-3 remain to be done. Speaking of > >EINTR, as we spoke about before, a number of these interfaces have no > >reason to block, and some of them even have no reason to make syscalls > >at all. If more work still needs to be done testing cases that would > >not fail except on an intentionally-broken implementation, that should > >be a project for *after* GSoC, not taking up your time when we're > >nearing the deadline. > > > >Rich > > When we spoke about this, afai can remember, you said that the ones > that block are of higher priority, which implies others should also > be tested ultimately, so I went ahead and made tests of all of those > that I knew about at the time. There's nothing wrong about that in itself, but I asked you just the other day to prioritize, and expanding the existing tests was relatively low priority. > Are you saying functions that return > EINTR but do not block aren't even part of the task? No, but you can't spend days on a test area that's mostly done adding tests that are just for completeness' sake when there's a whole lot else left to do. > Ok, can you please tell me which of the functions I've linked on IRC > I should test then? I can find out which one of those block, but I > don't know about syscalls. Can you tell me how I could discern > betwen them? In the future please post things like this to the list. A pastebin link on IRC is not going to get my attention, and it makes it hard to follow up discussion. Please don't use pastebins as a replacement for email. (Here is the link for reference: http://paste.debian.net/126277/) Any function with "attr" in its name surely only deals with modifying userspace data structures. The whole point of spinlocks is to be completely userspace. Init functions almost surely don't involve syscalls, and destroy functions almost surely don't either except possibly in certain contention cases where the caller must wait for another thread before it can complete destruction of the object. By and large, the list in the pastebin looks very low-priority for testing. In any case, please prioritize. Rich