From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/481 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: minor fixes Date: Sun, 25 Sep 2011 12:14:10 -0400 Message-ID: <20110925161410.GN132@brightrain.aerifal.cx> References: <20110925134725.GA24939@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1316967618 13384 80.91.229.12 (25 Sep 2011 16:20:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 25 Sep 2011 16:20:18 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-482-gllmg-musl=m.gmane.org@lists.openwall.com Sun Sep 25 18:20:13 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1R7rR7-0002C8-Pq for gllmg-musl@lo.gmane.org; Sun, 25 Sep 2011 18:20:13 +0200 Original-Received: (qmail 21592 invoked by uid 550); 25 Sep 2011 16:20:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 21581 invoked from network); 25 Sep 2011 16:20:11 -0000 Content-Disposition: inline In-Reply-To: <20110925134725.GA24939@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:481 Archived-At: On Sun, Sep 25, 2011 at 03:47:25PM +0200, Szabolcs Nagy wrote: > attached a few lines of small changes > > > * if the time.h fixme is because of the sigevent struct > declaration, then it can go away as posix says > "The tag sigevent shall be declared as naming an incomplete structure type, > the contents of which are described in the header." > > actually there is a much stronger statement as well: > "Inclusion of the header may make visible all symbols from the > header." OK, I guess this is what the comment was about. Actually I forgot what it was there for. :-) > * __syscall_ret: declaration should be consistent with the function > definition (argument is signed long) > > i think one of the (unsigned long) casts is unnecessary due to conversion > rules but it probably makes things more clear I want to keep the types from the function definition and fix the prototype. They were basically chosen so that the "ugly" (impl-defined) conversion (unsigned-to-signed) would always take place inside the implementation of this function, and the safe (signed-to-unsigned) conversion could take place implicitly in the caller if necessary. It probably doesn't matter but I thought it cleaner at the time. > * sbrk: changed prototype here as well to be consistent with the standard > > actually semantically ptrdiff_t is better (sbrk does p+arg, not p=arg) > but the standard uses intptr_t > > this change should not hurt as sbrk should not be used anyway.. > (i guess there is no architecture where intptr_t != ptrdiff_t) I agree, this is the right fix. > * __asctime: use new crash (i assume the *0=0 crash is deprecated now) Good catch. > * setpgid: pid_t return type is wrong (return value is an error code) This one too. Thanks! Rich