From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: missing extern "C" block
Date: Tue, 11 Oct 2011 00:10:15 -0400 [thread overview]
Message-ID: <20111011041015.GU132@brightrain.aerifal.cx> (raw)
In-Reply-To: <20111010204946.e90ac65a.idunham@lavabit.com>
On Mon, Oct 10, 2011 at 08:49:46PM -0700, Isaac Dunham wrote:
> On Mon, 10 Oct 2011 18:44:49 +0200
> Szabolcs Nagy <nsz@port70.net> wrote:
>
> > while we are fixing c++ compatibility
> > some headers with function prototypes
> > do not have extern "C" block for c++
>
> <snip list>
>
> I'm certainly not saying that this is the right way to handle it,
> but this is what GNU libc uses __BEGIN_DECLS & __END_DECLS for (in
> sys/cdefs.h).
Definitely not the right way. It's a lot slower, and it's not
immediately obvious to somebody reading the code what the definitions
of these macros might be. The right fix is the audit that was just
done, and applying the results of it to fix errors and omissions.
Rich
prev parent reply other threads:[~2011-10-11 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 16:44 Szabolcs Nagy
2011-10-11 3:49 ` Isaac Dunham
2011-10-11 4:10 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011041015.GU132@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).