From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/509 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] properly terminate linked link of dsos Date: Wed, 12 Oct 2011 10:01:41 -0400 Message-ID: <20111012140141.GX132@brightrain.aerifal.cx> References: <1318427173.165420.11829@legion> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1318428596 21489 80.91.229.12 (12 Oct 2011 14:09:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 12 Oct 2011 14:09:56 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-510-gllmg-musl=m.gmane.org@lists.openwall.com Wed Oct 12 16:09:52 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1RDzVH-0002AJ-M7 for gllmg-musl@lo.gmane.org; Wed, 12 Oct 2011 16:09:52 +0200 Original-Received: (qmail 11604 invoked by uid 550); 12 Oct 2011 14:09:51 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 11596 invoked from network); 12 Oct 2011 14:09:51 -0000 Content-Disposition: inline In-Reply-To: <1318427173.165420.11829@legion> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:509 Archived-At: On Wed, Oct 12, 2011 at 03:42:54PM +0200, Arvid Ephraim Picciani wrote: > --- > src/ldso/dynlink.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/ldso/dynlink.c b/src/ldso/dynlink.c > index 1b55e07..3f271aa 100644 > --- a/src/ldso/dynlink.c > +++ b/src/ldso/dynlink.c > @@ -375,6 +375,7 @@ static struct dso *load_library(const char *name) > p->name = p->buf; > strcpy(p->name, name); > > + p->tail = 0; > tail->next = p; > p->prev = tail; > tail = p; See line 357. This patch is a no-op. Rich