From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/527 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: unneeded mremap calls in realloc Date: Thu, 17 Nov 2011 00:02:53 -0500 Message-ID: <20111117050253.GS132@brightrain.aerifal.cx> References: <20111116004536.GV24939@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1321506946 28394 80.91.229.12 (17 Nov 2011 05:15:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Nov 2011 05:15:46 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-528-gllmg-musl=m.gmane.org@lists.openwall.com Thu Nov 17 06:15:36 2011 Return-path: Envelope-to: gllmg-musl@lo.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by lo.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1RQuJx-0005q0-Nz for gllmg-musl@lo.gmane.org; Thu, 17 Nov 2011 06:15:33 +0100 Original-Received: (qmail 9345 invoked by uid 550); 17 Nov 2011 05:15:32 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 9337 invoked from network); 17 Nov 2011 05:15:32 -0000 Content-Disposition: inline In-Reply-To: <20111116004536.GV24939@port70.net> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:527 Archived-At: On Wed, Nov 16, 2011 at 01:45:37AM +0100, Szabolcs Nagy wrote: > (there might be better fix, eg why oldlen is not a > multiple of pagesize in the first place?) oldlen was computed in terms of CHUNK_SIZE macro, which was incorrect for mmapped chunks (masking off too many bits). should be fixed now. Rich