From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: unneeded mremap calls in realloc
Date: Thu, 17 Nov 2011 13:31:24 +0100 [thread overview]
Message-ID: <20111117123124.GW24939@port70.net> (raw)
In-Reply-To: <20111117050253.GS132@brightrain.aerifal.cx>
* Rich Felker <dalias@aerifal.cx> [2011-11-17 00:02:53 -0500]:
> On Wed, Nov 16, 2011 at 01:45:37AM +0100, Szabolcs Nagy wrote:
> > (there might be better fix, eg why oldlen is not a
> > multiple of pagesize in the first place?)
>
> oldlen was computed in terms of CHUNK_SIZE macro, which was incorrect
> for mmapped chunks (masking off too many bits). should be fixed now.
>
> Rich
btw in realloc there is this comment:
/* FIXME: find what's wrong here and reenable it..? */
if (0 && n > n1 && alloc_rev(self)) {
self = PREV_CHUNK(self);
n1 += CHUNK_SIZE(self);
}
can it be that the CHUNK_SIZE fix solves this as well?
prev parent reply other threads:[~2011-11-17 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 0:45 Szabolcs Nagy
2011-11-17 2:50 ` Rich Felker
2011-11-17 5:02 ` Rich Felker
2011-11-17 12:31 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117123124.GW24939@port70.net \
--to=nsz@port70.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).