From: Isaac Dunham <idunham@lavabit.com>
To: musl@lists.openwall.com
Subject: Re: Namespace issues, missing functions, _BSD_SOURCE for unistd.h
Date: Thu, 5 Apr 2012 18:03:07 -0700 [thread overview]
Message-ID: <20120405180307.38e2b00f@newbook> (raw)
In-Reply-To: <20120406001049.GA8803@brightrain.aerifal.cx>
> There is no "ANSI" namespace in unistd.h because it's not a standard C
> header but a POSIX header. It's definitely correct for POSIX 2008 base
> as-is without any patching.
Should have checked that.
I guess it will be a rewrite then.
Which profiles are you aiming to support? Latest versions only for
POSIX, ISO, and X/Open? Or only versions in the past decade?
I don't see any signs of version checks, so I assume you want POSIX2008
and XOPEN2008 (_XOPEN_SOURCE >= 700) only, and no support for SUSv3.
This will make the patch a lot smaller and cleaner.
> > BSD || XOPEN means the macro test should be
> > #if defined(_BSD_SOURCE) || defined(_XOPEN_SOURCE)
> > I see glibc turns on both of these with _GNU_SOURCE.
> Yes, I think you overlooked some of the logic of how glibc's
> features.h works...
Tried to decode it, but it's pretty easy to lose track (especially in
the ifdef nest that handles XOPEN_SOURCE).
> > Misplaced (should be BSD || XOPEN):
> > (Properly, these require XOPEN >= 500)
> > usleep, ualarm, fchown, fchdir, lchown,vhangup,
> > apparently fsync?
> All incorrect.
> usleep and ualarm were removed by SUSv4/POSIX 2008 and thus do not
> belong in any profile except ones with nonstandard extensions.
> fchown, fchdir, and lchown are all POSIX 2008 base.
> vhangup was perhaps standard at one time but removed
OK. _GNU_SOURCE || _BSD_SOURCE
It's _XOPEN_SOURCE == 500 || 600, which I take it will not be supported.
<snip>
> AFAIK most of these do not exist in musl at the moment.
Guessed that. It was meant as a comment on the status.
> > BSD||GNU:
..
> > +#if defined(_BSD_SOURCE) && !defined(L_SET)
> > +#define L_SET
> > +#define L_INCR
> > +#define L_XTND
> > +#endif
Forgot to add the SEEK_SET, etc. here.
Should be
#define L_SET SEEK_SET
..
hence the placement.
> > +#if !( (_POSIX_SOURCE - 0) < 200112L )
> > +int seteuid(uid_t);
> > +int setegid(gid_t);
> > +#endif
>
> I have no intention of trying to make a profile that conforms to the
> 1990 version of POSIX.
Forgot they went from straight from 1993 to 2001; I'll take that test
out.
>
> > +#if defined(_BSD_SOURCE) || ...
> > +pid_t vfork(void);
> > +int vhangup(void);
> > +int usleep(unsigned);
> > +unsigned ualarm(unsigned, unsigned);
>
> And these do not exist in SUSv4. (The first two are not in SUSv3
> either.)
Will fix.
Thanks for the comments.
Isaac Dunham
next prev parent reply other threads:[~2012-04-06 1:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 22:55 Isaac Dunham
2012-04-06 0:10 ` Rich Felker
2012-04-06 1:03 ` Isaac Dunham [this message]
2012-04-06 1:52 ` Rich Felker
2012-04-06 1:45 ` [PATCH] _BSD_SOURCE for unistd.h, take 2 Isaac Dunham
2012-04-06 2:04 ` Rich Felker
2012-04-06 2:40 ` Isaac Dunham
2012-04-06 2:51 ` Rich Felker
2012-04-06 14:48 ` Rich Felker
2012-04-06 15:48 ` Isaac Dunham
2012-04-06 23:32 ` Rich Felker
2012-04-07 5:47 ` Isaac Dunham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405180307.38e2b00f@newbook \
--to=idunham@lavabit.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).