From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/686 Path: news.gmane.org!not-for-mail From: Isaac Dunham Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] _BSD_SOURCE for unistd.h, take 2 Date: Thu, 5 Apr 2012 19:40:45 -0700 Message-ID: <20120405194045.071ee515@newbook> References: <20120405155508.0f782675@newbook> <20120406001049.GA8803@brightrain.aerifal.cx> <20120405184534.77ad0b4b@newbook> <20120406020435.GC8803@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1333680064 945 80.91.229.3 (6 Apr 2012 02:41:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2012 02:41:04 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-687-gllmg-musl=m.gmane.org@lists.openwall.com Fri Apr 06 04:41:03 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SFz6i-0002Hx-Ba for gllmg-musl@plane.gmane.org; Fri, 06 Apr 2012 04:41:00 +0200 Original-Received: (qmail 1759 invoked by uid 550); 6 Apr 2012 02:40:59 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 1748 invoked from network); 6 Apr 2012 02:40:59 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=yfrmvm1a5AoS5Nzh/Fb+uROJFQhkWS3/iyLDsEtA+VnyGpMpmRTdUvD6bepztk07FUxl9FsnwHB8XgUUOATZDyq1N7IO8Uj+Aa9CNPU4xqNwzl0YU3/D7/pZthj+ZluJz56sY7oWpdJXgiRjKNcJoW2hHtQI0zU2k2a9cM9eRbg=; h=Date:From:To:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding; In-Reply-To: <20120406020435.GC8803@brightrain.aerifal.cx> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.20.1; i486-pc-linux-gnu) Xref: news.gmane.org gmane.linux.lib.musl.general:686 Archived-At: On Thu, 5 Apr 2012 22:04:35 -0400 Rich Felker wrote: > > If I wanted to make things a little easier on those porting, I might > > add something like this when _BSD_SOURCE is defined: > > #warn "BSD setpgrp should be changed to setpgid" > > That's not essential, though. > The mismatching prototype should be enough to get a nice error. :) Sometimes I enjoy having a hint about how to change it, rather than needing to read the glibc headers... I put #warn instead of #error because they could well be using only the other _BSD_SOURCE functions. > Anyway, patch looks good now. Should I start committing or do you want > to prepare a unified patch for all the headers? Feel free to start committing. I may not be able to get all of the headers very soon, with my classes. But this patch alone should solve at least one of Rob Landley's issues with toybox (namely, chroot()). Isaac Dunham