From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/685 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] _BSD_SOURCE for unistd.h, take 2 Date: Thu, 5 Apr 2012 22:04:35 -0400 Message-ID: <20120406020435.GC8803@brightrain.aerifal.cx> References: <20120405155508.0f782675@newbook> <20120406001049.GA8803@brightrain.aerifal.cx> <20120405184534.77ad0b4b@newbook> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1333677788 20484 80.91.229.3 (6 Apr 2012 02:03:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2012 02:03:08 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-686-gllmg-musl=m.gmane.org@lists.openwall.com Fri Apr 06 04:03:07 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SFyVw-0006jf-Ry for gllmg-musl@plane.gmane.org; Fri, 06 Apr 2012 04:03:01 +0200 Original-Received: (qmail 20234 invoked by uid 550); 6 Apr 2012 02:03:00 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 20226 invoked from network); 6 Apr 2012 02:03:00 -0000 Content-Disposition: inline In-Reply-To: <20120405184534.77ad0b4b@newbook> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:685 Archived-At: On Thu, Apr 05, 2012 at 06:45:34PM -0700, Isaac Dunham wrote: > This is what was left from the comments. > > This adds L_SET & co., and defines 5 functions that had been under > _GNU_SOURCE only, when _BSD_SOURCE is defined. > If I wanted to make things a little easier on those porting, I might > add something like this when _BSD_SOURCE is defined: > #warn "BSD setpgrp should be changed to setpgid" > That's not essential, though. The mismatching prototype should be enough to get a nice error. :) Anyway, patch looks good now. Should I start committing or do you want to prepare a unified patch for all the headers? Rich