From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/689 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] _BSD_SOURCE in math.h; MAXFLOAT is XOPEN only Date: Fri, 6 Apr 2012 09:14:48 -0400 Message-ID: <20120406131448.GE8803@brightrain.aerifal.cx> References: <20120405223227.4d1ecb2b@newbook> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1333717995 16315 80.91.229.3 (6 Apr 2012 13:13:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2012 13:13:15 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-690-gllmg-musl=m.gmane.org@lists.openwall.com Fri Apr 06 15:13:14 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SG8yX-0004aZ-Qc for gllmg-musl@plane.gmane.org; Fri, 06 Apr 2012 15:13:13 +0200 Original-Received: (qmail 24100 invoked by uid 550); 6 Apr 2012 13:13:12 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 24092 invoked from network); 6 Apr 2012 13:13:12 -0000 Content-Disposition: inline In-Reply-To: <20120405223227.4d1ecb2b@newbook> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:689 Archived-At: On Thu, Apr 05, 2012 at 10:32:27PM -0700, Isaac Dunham wrote: > This is pretty minor for the most part. > There was one issue I noticed: > _GNU_SOURCE defines MAXFLOAT here, but glibc only defines it if I'll add HUGE for _GNU_SOURCE, but I don't see any reason to duplicate the other ugly logic which was probably just a mistake anyway. To clarify the general policy: In musl, _GNU_SOURCE or _BSD_SOURCE should not break or remove functionality specified by the actual standards. They should just add the missing nonstandard stuff associated with GNU or BSD. Further, so far _GNU_SOURCE has been a superset of _XOPEN_SOURCE (i.e. anything under defined(_XOPEN_SOURCE) has ||defined(_GNU_SOURCE) with it). If it turns out this is a bad idea, I'm not entirely opposed to changing that, but just matching the exact set of definitions provided by glibc for its own sake is not a good enough reason to change. The goal is always compatibility with applications, not matching glibc. Rich