From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/713 Path: news.gmane.org!not-for-mail From: Isaac Dunham Newsgroups: gmane.linux.lib.musl.general Subject: compatability: struct sigaction missing sa_restorer Date: Fri, 13 Apr 2012 19:20:18 -0700 Message-ID: <20120413192018.1a7e3612@newbook> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1334370041 3221 80.91.229.3 (14 Apr 2012 02:20:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2012 02:20:41 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-714-gllmg-musl=m.gmane.org@lists.openwall.com Sat Apr 14 04:20:40 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SIsbL-0003cM-Fn for gllmg-musl@plane.gmane.org; Sat, 14 Apr 2012 04:20:35 +0200 Original-Received: (qmail 16153 invoked by uid 550); 14 Apr 2012 02:20:34 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 16145 invoked from network); 14 Apr 2012 02:20:34 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=N072f/5y2FLfL4uqaajg3ROQpOWLiAvbiN/7xeFbFnKKmBnaSqrCIRt/kZYgPaQ4eg/wJMWE7HaqFwNSuf6yVGKFKL4qS9duKkc+SnNDd6vSJ9SVEsDfFzPWX/SRieIVr9NOqx4njfu2JWkPJf/wXcD6psx9/h5bTvu7bz8hHJo=; h=Date:From:To:Subject:Message-ID:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding; X-Mailer: Claws Mail 3.7.4 (GTK+ 2.20.1; i486-pc-linux-gnu) Xref: news.gmane.org gmane.linux.lib.musl.general:713 Archived-At: Kernel headers (asm/signal.h) and glibc headers agree that struct sigaction should have sa_restorer; musl provides __sa_restorer This is not mandated in X/Open or POSIX, AFAICT. However, the specification says "struct sigaction includes at least the following members", so here the glibc/kernel approach is conformant, as well as being simple and obvious--as opposed to the possible approach: #ifdef _GNU_SOURCE || _BSD_SOURCE #define sa_restorer .... #endif This prevents building Xvesa; I definitely won't patch it to use __sa_restorer. Don't know if sa_restorer is commonly used. I think that's the last issue, but could be wrong. As far as __[gu]id_t goes: $ grep -r __[gu]id_t /usr/include|wc -l 101 So that's a fair-sized problem (sed already posted, fwiw).