From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: configure script for musl (?!)
Date: Wed, 2 May 2012 11:39:03 -0400 [thread overview]
Message-ID: <20120502153903.GQ14673@brightrain.aerifal.cx> (raw)
In-Reply-To: <20120502150543.GB18084@openwall.com>
On Wed, May 02, 2012 at 07:05:43PM +0400, Solar Designer wrote:
> I think the biggest problem here is in the failure mode. In the draft
> script you posted, if "set -C" fails the script will proceed to
> potentially clobber a file via a (sym)link provided by another user, or
> it may use a FIFO or a regular file pre-created by another user (and set
> to e.g. mode 666), in which case the input to the compiler would be
> under that other user's control (even if we're running with a safe umask).
Since set is a shell builtin, I was assuming it won't fail, but I can
add "|| fail msg_here" to it.
> > I've actually been working on the issue and updated it to use $$,
> > $PPID, and a retry counter, so random failures will be extremely rare.
> > If anyone thinks it still matters, I'll add $(date|cksum) too.
>
> Oh, I think it's better to simply use the approach I suggested last:
>
> > > Rather than use $TMPDIR or /tmp, I think it'd be safer to place the file
> > > in the same directory with the configure script or in the current
I agree. In that case, secure creation is mostly a non-issue.
Rich
next prev parent reply other threads:[~2012-05-02 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 22:54 Rich Felker
2012-05-01 23:39 ` Rich Felker
2012-05-02 14:00 ` Solar Designer
2012-05-02 14:31 ` Rich Felker
2012-05-02 15:05 ` Solar Designer
2012-05-02 15:39 ` Rich Felker [this message]
2012-05-02 15:41 ` Solar Designer
2012-05-02 16:26 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502153903.GQ14673@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).