From: Isaac Dunham <idunham@lavabit.com>
To: musl@lists.openwall.com
Subject: Re: SIG_* in signal.h
Date: Wed, 16 May 2012 20:49:08 -0700 [thread overview]
Message-ID: <20120516204908.3630de56@newbook> (raw)
In-Reply-To: <20120517001416.GV163@brightrain.aerifal.cx>
On Wed, 16 May 2012 20:14:16 -0400
Rich Felker <dalias@aerifal.cx> wrote:
> On Thu, May 17, 2012 at 12:12:27AM +0200, Szabolcs Nagy wrote:
> > i just tried to compile pcc using musl
> > and it failed because SIG_IGN was undefined
> >
> > it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> > with various featuretest macros in signal.h
> > eventhough they are ansic
>
> Are you sure? I don't see that problem in my version and as far as I
> know I fixed that bug about a year ago...
Don't see it here, either. OTOH, it's not easy to see that it isn't the
case.
Line 205 marks the end of the #ifdef _EVERYBODY_AND_HIS_DOG_SOURCE
macros, which start at lines 8 & 9. I'd like to see an editor where
you can tell that without reading every line in between...(not to start
a war over editors, mind you!)
This is where I see a reason for stuff like:
#endif /* XOPEN/GNU/POSIX */
A comment after every endif (like glibc does) is rather absurd, though.
And it seems to me that usually the non-macro-protected code goes on
top, making it clearer what is ANSI...
Not to say that it's wrong, just that it could be clearer.
Isaac Dunham
next prev parent reply other threads:[~2012-05-17 3:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 22:12 Szabolcs Nagy
2012-05-16 23:05 ` Isaac Dunham
2012-05-16 23:11 ` Szabolcs Nagy
2012-05-16 23:21 ` Szabolcs Nagy
2012-05-17 0:06 ` Isaac Dunham
2012-05-17 0:14 ` Rich Felker
2012-05-17 3:49 ` Isaac Dunham [this message]
2012-05-17 6:53 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120516204908.3630de56@newbook \
--to=idunham@lavabit.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).