mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Isaac Dunham <idunham@lavabit.com>
To: musl@lists.openwall.com
Subject: getpass misplaced
Date: Sun, 20 May 2012 19:25:50 -0700	[thread overview]
Message-ID: <20120520192550.2cef3782@newbook> (raw)

I know getpass is an atrocious security mistake of years ago, but
if we are going to support it, glibc defines it with GNU, BSD, or *old*
X/Open feature macros in <unistd.h>, not <pwd.h>.

Also, I've found two more headers that actually don't need _BSD_SOURCE
added before they offer the BSD functionality (all BSD functions are
also available in every other relevant namespace): pwd.h and utmp.h.

This has me down to 22 headers that still need work/reviewing. Here's
the TODO for _BSD_SOURCE:

include/tgmath.h
include/glob.h
include/arpa/inet.h
include/sys/select.h
include/sys/wait.h
include/sys/socket.h
include/sys/un.h
include/sys/uio.h
include/sys/mman.h
include/sys/stat.h
include/setjmp.h
include/dirent.h
include/time.h
include/netinet/ip.h
include/netinet/tcp.h
include/netinet/ip_icmp.h
include/netinet/in.h		Missing structs
include/netinet/if_ether.h
include/shadow.h
include/endian.h
include/grp.h
include/net/if.h

<netinet/in.h> could cause breakage without extension.  I forget
exactly what the problem was, though.
Isaac Dunham



             reply	other threads:[~2012-05-21  2:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21  2:25 Isaac Dunham [this message]
2012-05-21  3:01 ` Rich Felker
2012-05-21  3:38   ` Isaac Dunham
2012-05-21  4:52   ` Question on setjmp.h Isaac Dunham
2012-05-21  4:53     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120520192550.2cef3782@newbook \
    --to=idunham@lavabit.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).