Re: getpass misplaced

[Rich Felker <dalias@aerifal.cx>]

On Sun, May 20, 2012 at 07:25:50PM -0700, Isaac Dunham wrote:
> I know getpass is an atrocious security mistake of years ago, but
> if we are going to support it, glibc defines it with GNU, BSD, or *old*
> X/Open feature macros in <unistd.h>, not <pwd.h>.

Fixed.

> Also, I've found two more headers that actually don't need _BSD_SOURCE
> added before they offer the BSD functionality (all BSD functions are
> also available in every other relevant namespace): pwd.h and utmp.h.

OK.

> This has me down to 22 headers that still need work/reviewing. Here's
> the TODO for _BSD_SOURCE:
> 
> include/tgmath.h

This is purely C99 stuff; I don't think GNU would add anything.

> include/glob.h

We don't support the extensions here, and even if we want to have the
macros for extension flags, they seem to be in the reserved namespace
and thus ok to defined unconditionall.

> include/shadow.h
> include/endian.h

These are nonstandard and in principle don't need any feature test
macros. However, we use them in endian.h so that other headers can
include endian.h.

> <netinet/in.h> could cause breakage without extension.  I forget
> exactly what the problem was, though.

..what?

Rich