mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: A little more progress today with clang/LLVM
Date: Mon, 21 May 2012 22:53:06 -0400	[thread overview]
Message-ID: <20120522025306.GR163@brightrain.aerifal.cx> (raw)
In-Reply-To: <2233705.A3NXMro2gt@main.pennware.com>

On Mon, May 21, 2012 at 09:35:59PM -0500, Richard Pennington wrote:
> I'll send you the list. The only one that looked sort of bad to me was the out 
> of bounds array reference. It was on the x86_64 in the pthread_barrier_t 
> access. clang complained about referencing __p[4], which is out of bounds. 
> That code is a little cryptic to me right now, since I'm a newbi. ;-)

Thanks! Indeed, that's broken. I must not have noticed since I'm on
x86 (32-bit). The situation with the definition of these types is
unfortunate and I might eventually change it; basically, to avoid
leaking implementation details in the public headers, and to avoid
having to change the bits headers for all archs if I change the way
these primitives work, the public headers just have a union with ints
and pointers matching the ABI's size for the type, and pthread_impl.h
has macros that map fields into these slots in such a way that the
mapping works on both 32- and 64-bit systems.

Fixing now...

Rich


  reply	other threads:[~2012-05-22  2:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  1:47 Richard Pennington
2012-05-22  1:59 ` Rich Felker
2012-05-22  2:35   ` Richard Pennington
2012-05-22  2:53     ` Rich Felker [this message]
2012-05-22  3:24       ` Richard Pennington
2012-05-25 18:56   ` Richard Pennington
2012-05-25 23:09     ` Rich Felker
2012-05-26 11:30       ` Richard Pennington
2012-05-26 11:39         ` Richard Pennington
2012-05-26 12:49           ` Szabolcs Nagy
2012-05-26 11:59         ` Richard Pennington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522025306.GR163@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).