From: Isaac Dunham <idunham@lavabit.com>
To: musl@lists.openwall.com
Subject: Re: printf POSIX compliance
Date: Fri, 8 Jun 2012 19:33:57 -0700 [thread overview]
Message-ID: <20120608193357.40fb538d@newbook> (raw)
In-Reply-To: <CAOnWdoivcwhGoEELHZN5Pasj0eZC+bzFJ2DBfT5cuUHXT0ZCDg@mail.gmail.com>
On Fri, 8 Jun 2012 17:46:10 +0100
Reuben Thomas <rrt@sc3d.org> wrote:
> As regards the particular problem with freadahead, looking at the code
> suggests a workaround of -DSLOW_BUT_NO_HACKS to avoid trying to build
> the FILE-fiddling code.
Having looked at that code myself, I think there's some idiotic tests
going on:
#ifdef __OSNAME
..
#else if __system2__
..
#else if SLOW_BUT_NO_HACKS
//return 1
#else
//build error
#endif
1. If I define SLOW_BUT_NO_HACKS, it should be the first test.
(if I run MINT and define this, assume I mean it!)
2. If it works with a stub, why do we get an error?
I'd suggest more-or-less this approach:
-#else if SLOW_BUT_NO_HACKS
+#else
//return 1
-#else
-//build error
+//warn "falling back to stub, please port"
#endif
Of course, I know this isn't the right place to discuss such
things--that would be for gnulib.
Isaac Dunham
next prev parent reply other threads:[~2012-06-09 2:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 10:34 Reuben Thomas
2012-06-08 12:19 ` Luca Barbato
2012-06-08 12:32 ` Reuben Thomas
2012-06-08 14:04 ` Szabolcs Nagy
2012-06-08 14:16 ` Rich Felker
2012-06-08 14:44 ` Rich Felker
2012-06-08 14:55 ` Rich Felker
2012-06-08 15:06 ` Szabolcs Nagy
2012-06-08 15:29 ` Rich Felker
2012-06-08 15:43 ` Reuben Thomas
2012-06-08 15:53 ` Rich Felker
2012-06-08 16:16 ` Reuben Thomas
2012-06-08 16:38 ` John Spencer
2012-06-08 16:37 ` Reuben Thomas
2012-06-09 7:43 ` John Spencer
2012-06-09 14:17 ` Reuben Thomas
2012-06-08 16:46 ` John Spencer
2012-06-08 16:46 ` Reuben Thomas
2012-06-08 16:51 ` Rich Felker
2012-06-08 16:58 ` Reuben Thomas
2012-06-08 17:00 ` Rich Felker
2012-06-08 17:07 ` Reuben Thomas
2012-06-08 23:25 ` Rich Felker
2012-06-09 2:33 ` Isaac Dunham [this message]
2012-06-09 2:45 ` Rich Felker
2012-06-09 12:58 ` Szabolcs Nagy
2012-06-09 14:17 ` Reuben Thomas
2012-06-09 21:11 ` Rich Felker
2012-06-09 21:24 ` Reuben Thomas
2012-06-09 14:15 ` Reuben Thomas
2012-06-11 9:37 Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120608193357.40fb538d@newbook \
--to=idunham@lavabit.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).