From: orc <orc@sibserver.ru>
To: musl@lists.openwall.com
Subject: Re: linux/if_ether.h: struct ethhdr previously defined in netinet/if_ether.h
Date: Sat, 9 Jun 2012 14:51:48 +0800 [thread overview]
Message-ID: <20120609145148.2cb4358f@sibserver.ru> (raw)
In-Reply-To: <20120608221929.GV163@brightrain.aerifal.cx>
On Fri, 8 Jun 2012 18:19:29 -0400
Rich Felker <dalias@aerifal.cx> wrote:
> On Sat, Jun 09, 2012 at 03:04:49AM +0800, orc wrote:
> > Getting this when compiling tinc-1.0.18:
> >
> > In file included from /usr/include/linux/if_tun.h:20,
> > from device.c:24:
> > /usr/include/linux/if_ether.h:126: error: redefinition of 'struct
> > ethhdr' make[2]: *** [device.o] Error 1
> >
> > Commenting struct ethhdr definition in netinet/if_ether.h solves the
> > problem.
>
> I'm not sure how this stuff is intended to work with other libcs, but
> generally it's an error to be including both kernel headers and
> userspace headers that involve the same stuff in the same source
> file...
>
> And it's probably bad design to be including linux/*.h at all...
>
> Rich
Yes, but it includes other header missing in userspace
(linux/if_tun.h) for specific feature, which includes linux/if_ether.h
and fails due to already included netinet/if_ether.h. glibc2's
if_ether.h just sucks definitions from linux/if_ether.h
prev parent reply other threads:[~2012-06-09 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 19:04 orc
2012-06-08 22:19 ` Rich Felker
2012-06-09 6:51 ` orc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120609145148.2cb4358f@sibserver.ru \
--to=orc@sibserver.ru \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).