From: Solar Designer <solar@openwall.com>
To: musl@lists.openwall.com
Subject: Re: FreeSec crypt()
Date: Wed, 13 Jun 2012 17:18:07 +0400 [thread overview]
Message-ID: <20120613131807.GA22380@openwall.com> (raw)
In-Reply-To: <20120613125839.GB163@brightrain.aerifal.cx>
On Wed, Jun 13, 2012 at 08:58:39AM -0400, Rich Felker wrote:
> On Wed, Jun 13, 2012 at 08:10:32AM +0200, Szabolcs Nagy wrote:
> > > while (q - (u_char *) keybuf < sizeof(keybuf)) {
> > > *q++ = *key << 1;
> >
> > implementation-defined signed shift
>
> Undefined. Right shifts are implementation-defined. Left-shifts are
> defined only for positive operands that don't overflow.
Right. I'm going to fix that.
> Note that even if the behavior were defined, this code seems to have
> different behavior for high bytes depending on the signedness of char.
Do you mean high bits (not bytes)? Why would signedness of char matter
if the behavior of the signed char overflowing left shift were defined?
Alexander
next prev parent reply other threads:[~2012-06-13 13:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 23:51 Solar Designer
2012-06-13 1:18 ` Rich Felker
2012-06-13 6:10 ` Szabolcs Nagy
2012-06-13 12:43 ` Solar Designer
2012-06-13 12:58 ` Rich Felker
2012-06-13 13:18 ` Solar Designer [this message]
2012-06-13 14:56 ` Rich Felker
2012-06-13 16:45 ` Solar Designer
2012-06-13 17:27 ` Rich Felker
2012-06-13 17:32 ` Szabolcs Nagy
2012-06-13 17:36 ` Rich Felker
2012-06-13 12:07 ` Solar Designer
2012-06-13 14:53 ` Rich Felker
2012-06-24 7:21 ` Solar Designer
2012-06-24 7:32 ` Solar Designer
2012-06-25 3:51 ` Rich Felker
2012-06-29 5:25 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613131807.GA22380@openwall.com \
--to=solar@openwall.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).