From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1112 Path: news.gmane.org!not-for-mail From: Solar Designer Newsgroups: gmane.linux.lib.musl.general Subject: Re: FreeSec crypt() Date: Wed, 13 Jun 2012 17:18:07 +0400 Message-ID: <20120613131807.GA22380@openwall.com> References: <20120612235113.GA21296@openwall.com> <20120613011842.GA163@brightrain.aerifal.cx> <20120613061032.GH17860@port70.net> <20120613125839.GB163@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1339593497 12874 80.91.229.3 (13 Jun 2012 13:18:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Jun 2012 13:18:17 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1113-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 13 15:18:16 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SenSb-00030c-4x for gllmg-musl@plane.gmane.org; Wed, 13 Jun 2012 15:18:09 +0200 Original-Received: (qmail 32056 invoked by uid 550); 13 Jun 2012 13:18:09 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 32048 invoked from network); 13 Jun 2012 13:18:09 -0000 Content-Disposition: inline In-Reply-To: <20120613125839.GB163@brightrain.aerifal.cx> User-Agent: Mutt/1.4.2.3i Xref: news.gmane.org gmane.linux.lib.musl.general:1112 Archived-At: On Wed, Jun 13, 2012 at 08:58:39AM -0400, Rich Felker wrote: > On Wed, Jun 13, 2012 at 08:10:32AM +0200, Szabolcs Nagy wrote: > > > while (q - (u_char *) keybuf < sizeof(keybuf)) { > > > *q++ = *key << 1; > > > > implementation-defined signed shift > > Undefined. Right shifts are implementation-defined. Left-shifts are > defined only for positive operands that don't overflow. Right. I'm going to fix that. > Note that even if the behavior were defined, this code seems to have > different behavior for high bytes depending on the signedness of char. Do you mean high bits (not bytes)? Why would signedness of char matter if the behavior of the signed char overflowing left shift were defined? Alexander