From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1211 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: musl bugs found through gnulib Date: Wed, 20 Jun 2012 09:32:55 +0200 Message-ID: <20120620073255.GY17860@port70.net> References: <20120609230541.47eac2de@newbook> <4FD55156.7050302@cs.ucla.edu> <20120611182202.1ee4d019@newbook> <12545931.v3ALTEUUx8@linuix> <20120620030445.GU163@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1340177594 10418 80.91.229.3 (20 Jun 2012 07:33:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2012 07:33:14 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1212-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jun 20 09:33:13 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ShFPX-00066l-RK for gllmg-musl@plane.gmane.org; Wed, 20 Jun 2012 09:33:08 +0200 Original-Received: (qmail 9460 invoked by uid 550); 20 Jun 2012 07:33:07 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 9451 invoked from network); 20 Jun 2012 07:33:07 -0000 Content-Disposition: inline In-Reply-To: <20120620030445.GU163@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:1211 Archived-At: * Rich Felker [2012-06-19 23:04:45 -0400]: > Some more updates.. > > On Mon, Jun 18, 2012 at 12:49:44AM +0200, Bruno Haible wrote: > > Replacement of perror, because of > > checking whether perror matches strerror... no > > this is a musl issue: diff --git a/src/stdio/perror.c b/src/stdio/perror.c index 4349ac5..fdcb4d7 100644 --- a/src/stdio/perror.c +++ b/src/stdio/perror.c @@ -10,7 +10,7 @@ void perror(const char *msg) FLOCK(f); - if (msg) { + if (msg && *msg) { fwrite(msg, strlen(msg), 1, f); fputc(':', f); fputc(' ', f);