From: Solar Designer <solar@openwall.com>
To: musl@lists.openwall.com
Subject: Re: FreeSec crypt()
Date: Sun, 24 Jun 2012 11:32:25 +0400 [thread overview]
Message-ID: <20120624073225.GA4435@openwall.com> (raw)
In-Reply-To: <20120624072112.GA3792@openwall.com>
On Sun, Jun 24, 2012 at 11:21:12AM +0400, Solar Designer wrote:
> struct _crypt_extended_shared {
> uint32_t psbox[8][64];
> uint32_t ip_maskl[16][16], ip_maskr[16][16];
> uint32_t fp_maskl[8][16], fp_maskr[8][16];
> uint32_t key_perm_maskl[8][16], key_perm_maskr[12][16];
> uint32_t comp_maskl0[4][8], comp_maskr0[4][8];
> uint32_t comp_maskl1[4][16], comp_maskr1[4][16];
> };
Actually, we should re-order the first two lines. That is make it:
struct _crypt_extended_shared {
uint32_t ip_maskl[16][16], ip_maskr[16][16];
uint32_t psbox[8][64];
uint32_t fp_maskl[8][16], fp_maskr[8][16];
uint32_t key_perm_maskl[8][16], key_perm_maskr[12][16];
uint32_t comp_maskl0[4][8], comp_maskr0[4][8];
uint32_t comp_maskl1[4][16], comp_maskr1[4][16];
};
That's because IP is not always used (it's only used for "new"-style
hashes, not for "old"-style ones where the initial block is always 0
and thus IP is skipped). When it is used, it's used right before
psbox[] is.
Alexander
next prev parent reply other threads:[~2012-06-24 7:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 23:51 Solar Designer
2012-06-13 1:18 ` Rich Felker
2012-06-13 6:10 ` Szabolcs Nagy
2012-06-13 12:43 ` Solar Designer
2012-06-13 12:58 ` Rich Felker
2012-06-13 13:18 ` Solar Designer
2012-06-13 14:56 ` Rich Felker
2012-06-13 16:45 ` Solar Designer
2012-06-13 17:27 ` Rich Felker
2012-06-13 17:32 ` Szabolcs Nagy
2012-06-13 17:36 ` Rich Felker
2012-06-13 12:07 ` Solar Designer
2012-06-13 14:53 ` Rich Felker
2012-06-24 7:21 ` Solar Designer
2012-06-24 7:32 ` Solar Designer [this message]
2012-06-25 3:51 ` Rich Felker
2012-06-29 5:25 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120624073225.GA4435@openwall.com \
--to=solar@openwall.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).