From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: Possible ARM struct stat problem.
Date: Mon, 25 Jun 2012 23:01:24 -0400 [thread overview]
Message-ID: <20120626030124.GI544@brightrain.aerifal.cx> (raw)
In-Reply-To: <19157184.cxXl8ahUNG@main.pennware.com>
On Mon, Jun 25, 2012 at 09:52:02PM -0500, Richard Pennington wrote:
> On Monday, June 25, 2012 10:50:02 PM Rich Felker wrote:
> > On Tue, Jun 26, 2012 at 04:15:25AM +0200, John Spencer wrote:
> > > >I'm not entirely opposed to putting the explicit padding in there,
> > > >since this is an arch-specific structure anyway, but I think you
> > > >should check your compiler. The same issue might come up elsewhere and
> > > >might not be so easy to work around.
> > >
> > > please apply the explicit padding.
> >
> > All this would have done is hide the issue that you're using the wrong
> > ABI (oabi instead of eabi) and make it harder to find the more-subtle
> > resulting bugs later (mildly different calling convention and
> > padding).
> >
> I agree with Rich on this one.
I'm wondering if there's somewhere in the source I could put a static
assertion to test for wrong ABI. Perhaps this belongs in the configure
script (but I know *ahem* some folks don't run configure).
Unfortunately the only C code that's arch-specific is in header files,
and none of them really seem like the appropriate place for static
assertions, so I'm not sure where to put it.
Rich
next prev parent reply other threads:[~2012-06-26 3:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 18:35 Richard Pennington
2012-05-27 19:43 ` Rich Felker
2012-05-27 23:03 ` Szabolcs Nagy
2012-05-28 13:13 ` Richard Pennington
2012-06-26 2:15 ` John Spencer
2012-06-26 2:50 ` Rich Felker
2012-06-26 2:52 ` Richard Pennington
2012-06-26 3:01 ` Rich Felker [this message]
2012-06-26 3:12 ` John Spencer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120626030124.GI544@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).