mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: openssh and sendmsg() problem
Date: Tue, 26 Jun 2012 12:01:06 -0400	[thread overview]
Message-ID: <20120626160106.GJ544@brightrain.aerifal.cx> (raw)
In-Reply-To: <20120626120017.GZ17860@port70.net>

On Tue, Jun 26, 2012 at 02:00:17PM +0200, Szabolcs Nagy wrote:
> * orc <orc@sibserver.ru> [2012-06-26 19:01:46 +0800]:
> > strace shows that sendmsg system call returns EINVAL:
> > 
> > sendmsg(5, {msg_name(0)=NULL, msg_iov(1)=[{"\0", 1}], msg_controllen=24, {cmsg_len=20, cmsg_level=SOL_SOCKET, cmsg_
> > type=SCM_RIGHTS, {4, 385875968}}, msg_flags=0}, 0) = -1 EINVAL (Invalid argument)
> > 
> 
> src/network/sendmsg.c has an ifdef for long>int case
> 
> i don't know what it's supposed to do

It's there because the kernel expects certain fields to be long but
POSIX requires them to be int. Thus the syscall wrapper has to copy
the userspace struct (with int and padding) to a kernel-format struct
(with the padding filled with 0's so it's a valid long).

> you may want to change the struct msghdr definition
> in arch/*/bits/socket.h
> (eg to the one in your /usr/include/bits/socket.h)
> and remove the ifdef from sendmsg.c

Nope, this is not valid. See above.

Rich


  reply	other threads:[~2012-06-26 16:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 11:01 orc
2012-06-26 12:00 ` Szabolcs Nagy
2012-06-26 16:01   ` Rich Felker [this message]
2012-06-26 17:24     ` orc
2012-06-26 17:32       ` Rich Felker
2012-06-26 18:16         ` orc
2012-06-26 19:08           ` Rich Felker
2012-06-26 19:39             ` orc
2012-06-26 20:40               ` Szabolcs Nagy
2012-06-26 21:13                 ` Rich Felker
2012-07-01 10:23                   ` orc
2012-06-26 18:32       ` John Spencer
2012-06-26 18:34         ` orc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120626160106.GJ544@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).