mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: thread local storage
Date: Mon, 16 Jul 2012 16:03:51 -0400	[thread overview]
Message-ID: <20120716200350.GN544@brightrain.aerifal.cx> (raw)
In-Reply-To: <50046559.3090204@barfooze.de>

On Mon, Jul 16, 2012 at 09:02:49PM +0200, John Spencer wrote:
> 2 out of 14 sabotage followers wanted to use a musl-based system as
> a platform for luajit (and then were never seen again).
> so i looked into adding it...
> 
> luajit builds without problems on musl, but then crashes due to a
> lack of TLS.

Then the gcc was built wrong. --disable-tls should be passed when
building gcc so that attempts to use __thread generate a compile error
(to be detected in configure).

> is it planned to add this feature ? iirc it wasn't mentioned on the
> latest roadmap...

Yes, but it's one of the hardest remainind things, for a couple
reasons...

1. It involves introducing ugly arch-specific code into lots of things
that should be arch-agnostic, because the original implementors did
things this way and encoding the knowledge into gcc. This might be
possible to bypass if we drop support for the static/local TLS model
or whatever they call it and force all modules, even the main program
and static binaries, to access TLS through a function call like shared
libs have to do. Actually I'd really like to do it this way if
possible since it would allow us to change things in the future
instead of locking in ABI stuff. At the very least it probably
requires a build option to GCC and/or a special -f flag in the spec
file or GCC default specs to make this possible.

2. Dynamic linker needs to be updtaed to handle all sorts of
TLS-related relocations which I don't yet understand, so I have to
read up on them...

3. Existing implementations of TLS are just _wrong_ and crashingly so.
When a new shared lib is loaded with dlopen, it may require additional
TLS memory, and this memory must be allocated for each thread
currently running. The way glibc/NPTL works is to keep a "generation
counter" and dynamically allocate space for each thread's new TLS on
the first accerss if the ldso generation counter has increased (or
something like that). If allocation fails, there's nothing you can do
but abort the program. Naturally this is unacceptable.

Fixing it requires temporarily placing a lock on new thread creation
and allocating the new TLS space for all currently-running threads as
part of the dlopen operation, then either assigning it to them before
dlopen returns, or placing it in a reserved pool whereby they can get
it on the first access attempt. Solving this problem correctly,
without race conditions or deadlocks, etc. is rather non-trivial.

Rich






  parent reply	other threads:[~2012-07-16 20:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-16 19:02 John Spencer
2012-07-16 18:57 ` Gregor Richards
2012-07-16 20:09   ` Rich Felker
2012-07-16 21:30     ` John Spencer
2012-07-16 22:18       ` Rich Felker
2012-07-16 19:58 ` Justin Cormack
2012-07-16 20:03 ` Rich Felker [this message]
2012-07-16 22:06   ` John Spencer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120716200350.GN544@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).