From: Isaac Dunham <idunham@lavabit.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/10] ioperm & iopl
Date: Mon, 6 Aug 2012 19:22:41 -0700 [thread overview]
Message-ID: <20120806192241.2ed1108f@newbook> (raw)
In-Reply-To: <20120722181332.191d4fa5@newbook>
On Sun, 22 Jul 2012 18:13:32 -0700
Isaac Dunham <idunham@lavabit.com> wrote:
> This adds ioperm & iopl along with io.h, though a full io.h has
> several more syscalls.
I've been looking into some fixes for the current state, and have a few
questions...
1. These are only appropriate on PC arches (plus a few old PC-like
systems, like Alpha). However, they are C, so make doesn't build them.
Should I add a per-arch *.c rule to the Makefile? (this seems better to
me than adding an #ifdef and building an empty file on other arches)
2. To add per-arch headers in include/sys/, should I
mkdir arch/${ARCH}/sys/
?
Will this require changing the makefile?
3. I'm thinking to copy in the macros, and would like a few tips on
style:
-I assume I should delete needless comments such as
/* Basic I/O macros */
..
#endif /* _SYS_IO_H */
-static inline or static ?
Thanks,
Isaac Dunham
next prev parent reply other threads:[~2012-08-07 2:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 1:13 Isaac Dunham
2012-07-23 1:17 ` [PATCH 2/10] splice Isaac Dunham
2012-07-23 1:21 ` [PATCH 3/10] xattr syscalls Isaac Dunham
2012-07-24 18:06 ` orc
2012-07-23 1:24 ` [PATCH 4/10] pipe2 Isaac Dunham
2012-07-23 1:28 ` [PATCH 5/10] __sigsetjmp alias Isaac Dunham
2012-07-23 1:32 ` [PATCH 6/10] Provide private versions of locale/ functions Isaac Dunham
2012-07-23 1:33 ` [PATCH 7/10] __fcntl Isaac Dunham
2012-07-23 1:36 ` [PATCH 8/10] finite Isaac Dunham
2012-07-23 7:58 ` Szabolcs Nagy
2012-07-23 1:38 ` [PATCH 9/10] GLIBC ABI patches Isaac Dunham
2012-07-23 15:11 ` Arvid E. Picciani
2012-07-24 18:15 ` Igmar Palsenberg
2012-07-24 18:19 ` Gregor Richards
2012-07-24 18:23 ` Igmar Palsenberg
2012-07-24 18:29 ` Gregor Richards
2012-07-24 18:33 ` Igmar Palsenberg
2012-07-24 23:18 ` Rich Felker
2012-07-25 7:27 ` Arvid E. Picciani
2012-07-25 14:12 ` Luca Barbato
2012-07-25 15:19 ` Rich Felker
2012-07-25 15:52 ` Luca Barbato
2012-07-25 17:35 ` Rich Felker
2012-07-25 23:06 ` idunham
2012-07-23 1:40 ` [PATCH 10/10] More glibc ABI compatability Isaac Dunham
2012-08-07 2:22 ` Isaac Dunham [this message]
2012-08-07 3:29 ` [PATCH 1/10] ioperm & iopl Isaac Dunham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806192241.2ed1108f@newbook \
--to=idunham@lavabit.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).