From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1438 Path: news.gmane.org!not-for-mail From: Isaac Dunham Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/10] ioperm & iopl Date: Mon, 6 Aug 2012 19:22:41 -0700 Message-ID: <20120806192241.2ed1108f@newbook> References: <20120722181332.191d4fa5@newbook> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344306177 18512 80.91.229.3 (7 Aug 2012 02:22:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 02:22:57 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1439-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 07 04:22:57 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SyZRh-0004Wp-CY for gllmg-musl@plane.gmane.org; Tue, 07 Aug 2012 04:22:57 +0200 Original-Received: (qmail 28540 invoked by uid 550); 7 Aug 2012 02:22:56 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 28532 invoked from network); 7 Aug 2012 02:22:56 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=BLuEiHJ58QLxKQ0eP11A7sWyJfYJoklOyk3+0wDzByJEpuh/8w00Cr0TxUZPyP7EGJ7CkL0IDuN6gGLmyA8el5RDQkOKgPmfwkiZF+CrZ4bOFOoUX6JFRmmH7OCbCJpWxI8w2Z3TAIcmijEEx+XrJUtgeT7Ax6KSXZ7aDdQ3JHg=; h=Date:From:To:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding; In-Reply-To: <20120722181332.191d4fa5@newbook> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.20.1; i486-pc-linux-gnu) Xref: news.gmane.org gmane.linux.lib.musl.general:1438 Archived-At: On Sun, 22 Jul 2012 18:13:32 -0700 Isaac Dunham wrote: > This adds ioperm & iopl along with io.h, though a full io.h has > several more syscalls. I've been looking into some fixes for the current state, and have a few questions... 1. These are only appropriate on PC arches (plus a few old PC-like systems, like Alpha). However, they are C, so make doesn't build them. Should I add a per-arch *.c rule to the Makefile? (this seems better to me than adding an #ifdef and building an empty file on other arches) 2. To add per-arch headers in include/sys/, should I mkdir arch/${ARCH}/sys/ ? Will this require changing the makefile? 3. I'm thinking to copy in the macros, and would like a few tips on style: -I assume I should delete needless comments such as /* Basic I/O macros */ .. #endif /* _SYS_IO_H */ -static inline or static ? Thanks, Isaac Dunham