mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: ldso : bug dependencies symbol lookup
Date: Tue, 7 Aug 2012 19:12:15 -0400	[thread overview]
Message-ID: <20120807231215.GD27715@brightrain.aerifal.cx> (raw)
In-Reply-To: <50212C76.8050909@gmail.com>

On Tue, Aug 07, 2012 at 04:55:50PM +0200, musl wrote:
> Hi,
> 
> I think there is a bug in symbol lookup since this commit : 05eff01e89ee345e70acdbebc9c3778766b76ee2.
> 
>         if (p->deps) for (i=0; p->deps[i]; i++) {
> -               sym = lookup(s, h, p->deps[i]->syms,
> -                       p->deps[i]->hashtab, p->deps[i]->strings);
> +               sym = lookup(s, h, p);
>                 if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
>                         return p->deps[i]->base + sym->st_value;
>         }
> 
> this should be :
> 
>         if (p->deps) for (i=0; p->deps[i]; i++) {
> -               sym = lookup(s, h, p->deps[i]->syms,
> -                       p->deps[i]->hashtab, p->deps[i]->strings);
> +               sym = lookup(s, h, p->deps[i]);
>                 if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
>                         return p->deps[i]->base + sym->st_value;
>         }

Thanks! Fixed in git.

Rich


      reply	other threads:[~2012-08-07 23:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 14:55 musl
2012-08-07 23:12 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807231215.GD27715@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).