* ldso : bug dependencies symbol lookup
@ 2012-08-07 14:55 musl
2012-08-07 23:12 ` Rich Felker
0 siblings, 1 reply; 2+ messages in thread
From: musl @ 2012-08-07 14:55 UTC (permalink / raw)
To: musl
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
Hi,
I think there is a bug in symbol lookup since this commit : 05eff01e89ee345e70acdbebc9c3778766b76ee2.
if (p->deps) for (i=0; p->deps[i]; i++) {
- sym = lookup(s, h, p->deps[i]->syms,
- p->deps[i]->hashtab, p->deps[i]->strings);
+ sym = lookup(s, h, p);
if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
return p->deps[i]->base + sym->st_value;
}
this should be :
if (p->deps) for (i=0; p->deps[i]; i++) {
- sym = lookup(s, h, p->deps[i]->syms,
- p->deps[i]->hashtab, p->deps[i]->strings);
+ sym = lookup(s, h, p->deps[i]);
if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
return p->deps[i]->base + sym->st_value;
}
Regards,
Boris
[-- Attachment #2: Type: text/html, Size: 10025 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ldso : bug dependencies symbol lookup
2012-08-07 14:55 ldso : bug dependencies symbol lookup musl
@ 2012-08-07 23:12 ` Rich Felker
0 siblings, 0 replies; 2+ messages in thread
From: Rich Felker @ 2012-08-07 23:12 UTC (permalink / raw)
To: musl
On Tue, Aug 07, 2012 at 04:55:50PM +0200, musl wrote:
> Hi,
>
> I think there is a bug in symbol lookup since this commit : 05eff01e89ee345e70acdbebc9c3778766b76ee2.
>
> if (p->deps) for (i=0; p->deps[i]; i++) {
> - sym = lookup(s, h, p->deps[i]->syms,
> - p->deps[i]->hashtab, p->deps[i]->strings);
> + sym = lookup(s, h, p);
> if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
> return p->deps[i]->base + sym->st_value;
> }
>
> this should be :
>
> if (p->deps) for (i=0; p->deps[i]; i++) {
> - sym = lookup(s, h, p->deps[i]->syms,
> - p->deps[i]->hashtab, p->deps[i]->strings);
> + sym = lookup(s, h, p->deps[i]);
> if (sym && sym->st_value && (1<<(sym->st_info&0xf) & OK_TYPES))
> return p->deps[i]->base + sym->st_value;
> }
Thanks! Fixed in git.
Rich
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-07 23:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-07 14:55 ldso : bug dependencies symbol lookup musl
2012-08-07 23:12 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).