From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1471 Path: news.gmane.org!not-for-mail From: Isaac Dunham Newsgroups: gmane.linux.lib.musl.general Subject: Re: crypt* files in crypt directory Date: Wed, 8 Aug 2012 16:08:10 -0700 Message-ID: <20120808160810.731cec78@newbook> References: <20120808022421.GE27715@brightrain.aerifal.cx> <20120808044235.GA22470@openwall.com> <20120808052844.GF27715@brightrain.aerifal.cx> <20120808062706.GA23135@openwall.com> <20120808214855.GL27715@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344467337 32024 80.91.229.3 (8 Aug 2012 23:08:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2012 23:08:57 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1472-gllmg-musl=m.gmane.org@lists.openwall.com Thu Aug 09 01:08:58 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SzFN3-0000wi-OH for gllmg-musl@plane.gmane.org; Thu, 09 Aug 2012 01:08:57 +0200 Original-Received: (qmail 13804 invoked by uid 550); 8 Aug 2012 23:08:56 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 13795 invoked from network); 8 Aug 2012 23:08:56 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=lavabit.com; b=FUfyVKfs+L1o0t3483HxLBkYyRIoeS3rPRU9vicAiLDdsT69Bh2CrZOevplt5AC21EmpdHT1rEmTjGzFrvUojx0dzTU2aMgeIlUXDro0zXRoivIUq5jp14cHi4LI6DEkqRg42fG40a5VITwRqxdONdb0tGpqxThotGnHPR9ZGRw=; h=Date:From:To:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding; In-Reply-To: <20120808214855.GL27715@brightrain.aerifal.cx> X-Mailer: Claws Mail 3.7.4 (GTK+ 2.20.1; i486-pc-linux-gnu) Xref: news.gmane.org gmane.linux.lib.musl.general:1471 Archived-At: On Wed, 8 Aug 2012 17:48:55 -0400 Rich Felker wrote: > > > Maybe you could support -DFAST_CRYPT or the like. It could enable > > > forced inlining and manual unrolls in crypt_blowfish.c. .. > Unless there's a really compelling reason to do so, I'd like to avoid > having multiple alternative versions of the same code in a codebase. > It makes it so there's more combinations you have to test to be sure > the code works and doesn't have regressions. > > As it stands, the code I posted with the manual unrolling removed > performs _better_ than the manually unrolled code with gcc 4 on x86_64 > when optimized for speed, and it's 33% smaller when optimized for > size. Per your own tests? I say this because the test previously mentioned shows the opposite: > > The impact on x86-64 is less. With Ubuntu 12.04's gcc 4.6.3 on > > FX-8120 I get 490 c/s for the original code, 450 c/s for your code > > without inlining/unrolling, and somehow only 430 c/s with > > -finline-functions -funroll-loops. that's : Raw %speed version 490 c/s 100% original 450 c/s 92% rich's version 430 c/s 88% rich's version, unrolled by compiler Higher is faster. IE, unrolling is actually slowing your version down more. GCC 3/x86 is getting 80% with rich's version, optimized. Also, how much "bloat" does solar designer's proposal (unroll inside BF_body) add? Isaac Dunham