From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1488 Path: news.gmane.org!not-for-mail From: Szabolcs Nagy Newsgroups: gmane.linux.lib.musl.general Subject: Re: crypt* files in crypt directory Date: Thu, 9 Aug 2012 19:30:53 +0200 Message-ID: <20120809173052.GI32316@port70.net> References: <20120808044235.GA22470@openwall.com> <20120808052844.GF27715@brightrain.aerifal.cx> <20120808062706.GA23135@openwall.com> <20120808214855.GL27715@brightrain.aerifal.cx> <20120809033613.GA24926@openwall.com> <20120809072940.GA26288@openwall.com> <20120809105348.GA27361@openwall.com> <20120809115811.GA32316@port70.net> <20120809164355.GA28398@openwall.com> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1344533480 13113 80.91.229.3 (9 Aug 2012 17:31:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2012 17:31:20 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1489-gllmg-musl=m.gmane.org@lists.openwall.com Thu Aug 09 19:31:19 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1SzWZe-00050k-49 for gllmg-musl@plane.gmane.org; Thu, 09 Aug 2012 19:31:06 +0200 Original-Received: (qmail 9507 invoked by uid 550); 9 Aug 2012 17:31:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 9499 invoked from network); 9 Aug 2012 17:31:04 -0000 Content-Disposition: inline In-Reply-To: <20120809164355.GA28398@openwall.com> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:1488 Archived-At: * Solar Designer [2012-08-09 20:43:55 +0400]: > On Thu, Aug 09, 2012 at 01:58:12PM +0200, Szabolcs Nagy wrote: > > i added review comments > > the style comments are subjective of course > > Thanks. Note that I deliberately did not merge Rich's cleanups yet in > order to be able to continue testing this as part of my tree, with its > wrapper.c still intact, etc. As discussed with Rich on IRC, I left > merging those changes for musl's use to Rich. ah ok thanks for the insightful answers i didn't know about the alpha thing (unsigned int cast may be needed in array index) and i'm not used to these low level optimizations (i prefer writing clean c assuming that the compiler is perfect, but i can see how that might not be the best approach in practice)