From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1535 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: Priorities for next release? Date: Sat, 11 Aug 2012 16:51:28 -0400 Message-ID: <20120811205128.GL27715@brightrain.aerifal.cx> References: <20120810191254.GA13232@brightrain.aerifal.cx> <20120811195649.GK27715@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1344718241 22472 80.91.229.3 (11 Aug 2012 20:50:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 11 Aug 2012 20:50:41 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1536-gllmg-musl=m.gmane.org@lists.openwall.com Sat Aug 11 22:50:42 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1T0Ids-0007KV-Db for gllmg-musl@plane.gmane.org; Sat, 11 Aug 2012 22:50:40 +0200 Original-Received: (qmail 11598 invoked by uid 550); 11 Aug 2012 20:50:39 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 11590 invoked from network); 11 Aug 2012 20:50:39 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:1535 Archived-At: On Sat, Aug 11, 2012 at 10:26:35PM +0200, Daniel Cegiełka wrote: > > Did I miss anything? Other additions to the wishlist for next release? > > Support for the man pages? This can be simple dir in musl > (man/man{1,2,...) and "--with-man" option in configure. Hm? Adding man pages for every interface would be a huge task, well outside of "finishing touches for the next release". :-) I'd actually like to find someone interested in writing detailed documentation (there was a thread about this a while back), but I'm not sure man pages are the best format; the POSIX man pages suffice as programmers' documentation for most of the interfaces in musl. > I'm sending fgetln.c (+my diff), but please check it... > btw. it based on /usr.bin/make/util.c from OpenBSD: If we add fgetln, I'd like a much higher quality of implementation. It's not clear from the past documentation I've read for this function that it's allowed to use a shared static buffer for all FILEs, and even if it were, I find that really ugly. Instead, simply returning a pointer into the FILE's buffer when the whole line is already present in the buffer, and otherwise allocating a FILE-local buffer for it, would be a lot nicer. fclose could then check the FILE-local pointer and free if it it was allocated. I was under the impression that this was how legacy BSD fgetln worked in the first place... Rich P.S. Just noticed another thing: K&R function arguments are not valid C99 or C11 and are not okay in musl.