From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/1573 Path: news.gmane.org!not-for-mail From: Solar Designer Newsgroups: gmane.linux.lib.musl.general Subject: Re: Todo for release? Date: Tue, 14 Aug 2012 02:06:01 +0400 Message-ID: <20120813220601.GA8817@openwall.com> References: <20120813185329.GA20024@brightrain.aerifal.cx> <20120813213154.GI20243@port70.net> <20120813215344.GB27715@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1344895564 17274 80.91.229.3 (13 Aug 2012 22:06:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 13 Aug 2012 22:06:04 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-1574-gllmg-musl=m.gmane.org@lists.openwall.com Tue Aug 14 00:06:06 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1T12lw-00062M-Id for gllmg-musl@plane.gmane.org; Tue, 14 Aug 2012 00:06:04 +0200 Original-Received: (qmail 13446 invoked by uid 550); 13 Aug 2012 22:06:03 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 13438 invoked from network); 13 Aug 2012 22:06:02 -0000 Content-Disposition: inline In-Reply-To: <20120813215344.GB27715@brightrain.aerifal.cx> User-Agent: Mutt/1.4.2.3i Xref: news.gmane.org gmane.linux.lib.musl.general:1573 Archived-At: On Mon, Aug 13, 2012 at 05:53:44PM -0400, Rich Felker wrote: > On Mon, Aug 13, 2012 at 11:31:54PM +0200, Szabolcs Nagy wrote: > > md5 based crypt is not recommended anymore > > http://phk.freebsd.dk/sagas/md5crypt_eol.html > > Indeed. But is it used in existing Linux user databases on any > significant scale? It is. > If not, I agree we can just drop it. We should support it. Maybe use my MD5 code, but for md5crypt write new code to avoid the beerware license (I would be happy to buy phk a beer, but having to mention another license for a component in musl's license is not nice). > I'm confused by all the SHA names (1/2/256/512)... You need sha512crypt and sha256crypt. SHA-1 is irrelevant (not used in any common crypt(3) flavor). SHA-2 is a common name for the SHA-224/256/384/512 primitives (although these are actually different). Of sha512crypt and sha256crypt, only the former is commonly used, but you may choose to support both anyway (systems generally support both). The high-level structure of md5crypt, sha512crypt, and sha256crypt is similar, but it'd be tricky/unreasonable to exploit that for reduced code size as you'd likely increase source code complexity and make the code slower (important in case of sha512crypt and sha256crypt, which support variable iteration counts). Alexander