Re: Todo for release?

[Szabolcs Nagy <nsz@port70.net>]

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

* Rich Felker <dalias@aerifal.cx> [2012-08-15 10:36:40 -0400]:
> On Wed, Aug 15, 2012 at 03:32:57PM +0200, Szabolcs Nagy wrote:
> > it seems warn(0) and err(1,0) segfault
> > (they should handle fmt==0 before passing
> > it to vfprintf)
> > and they do not print the ': ' nor the
> > __progname
> 
> Thanks for the report. This should be easy to fix. By the way, is it
> worth making these functions take a lock on the file for the whole
> operation (to make it atomic)? I'm leaning towards no, since they seem
> to only be used in legacy junk that's all single-threaded anyway.

i dont mind if the file is not locked although it would not
itroduce too much overhead..

the ": " is not fixed, i think that should be added


[-- Attachment #2: err.diff --]
[-- Type: text/x-diff, Size: 443 bytes --]

diff --git a/src/linux/err.c b/src/linux/err.c
index c291136..bc8a928 100644
--- a/src/linux/err.c
+++ b/src/linux/err.c
@@ -3,9 +3,15 @@
 #include <stdarg.h>
 #include <stdlib.h>
 
+/* basename(argv[0]) is not printed and stderr is not locked */
+
 void vwarn(const char *fmt, va_list ap)
 {
-	if (fmt) vfprintf(stderr, fmt, ap);
+	if (fmt) {
+		vfprintf(stderr, fmt, ap);
+		fputc(':', stderr);
+		fputc(' ', stderr);
+	}
 	perror("");
 }