mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: Help-wanted tasks for musl
Date: Wed, 29 Aug 2012 17:14:59 +0200	[thread overview]
Message-ID: <20120829151459.GJ1104@port70.net> (raw)
In-Reply-To: <20120829143012.GT27715@brightrain.aerifal.cx>

* Rich Felker <dalias@aerifal.cx> [2012-08-29 10:30:12 -0400]:
> see the attached for my proposed changes.
> 

looks ok

> /* key limit is not part of the original design, added for DoS protection */
> #define KEY_MAX 256
> #define SALT_MAX 16
> #define ROUNDS_DEFAULT 5000
> #define ROUNDS_MIN 1000
> #define ROUNDS_MAX 999999
> 

i'd add a comment like

/* max rounds limit is lower than in the reference */



  reply	other threads:[~2012-08-29 15:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-19  4:26 Rich Felker
2012-08-19  8:10 ` idunham
2012-08-19 16:18   ` William Haddon
2012-08-19  8:44 ` boris brezillon
2012-08-19 11:49 ` Szabolcs Nagy
2012-08-19 16:56   ` Szabolcs Nagy
2012-08-19 17:29     ` Szabolcs Nagy
2012-08-20  0:51       ` Rich Felker
2012-08-20  1:35         ` Szabolcs Nagy
2012-08-20  1:39           ` Rich Felker
2012-08-20  1:58             ` Szabolcs Nagy
2012-08-20  2:12               ` Rich Felker
2012-08-28 20:09                 ` Szabolcs Nagy
2012-08-28 23:35                   ` Szabolcs Nagy
2012-08-29  0:15                     ` Szabolcs Nagy
2012-08-29 14:30                     ` Rich Felker
2012-08-29 15:14                       ` Szabolcs Nagy [this message]
2012-08-29 17:01                         ` Rich Felker
2012-08-30  8:40                           ` Szabolcs Nagy
2012-08-19 21:46 idunham
2012-08-19 22:19 ` Gregor Richards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120829151459.GJ1104@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).