mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: musl 0.9.5 release and new website
Date: Tue, 18 Sep 2012 09:56:58 -0400	[thread overview]
Message-ID: <20120918135658.GJ254@brightrain.aerifal.cx> (raw)
In-Reply-To: <20120917073532.GM9428@port70.net>

On Mon, Sep 17, 2012 at 09:35:32AM +0200, Szabolcs Nagy wrote:
> * Rich Felker <dalias@aerifal.cx> [2012-09-16 23:02:41 -0400]:
> > On Sun, Sep 16, 2012 at 11:42:08PM +0200, Szabolcs Nagy wrote:
> > > is the 30K key limit reasonable?
> > 
> > I don't know; can you explain the motivation?
> > 
> 
> allowing 1G long key is clearly wrong because of dos

If time only grows linearly with key length and 30k is no problem, I
suspect the runtime for a 1G key is annoying but not the biggest
problem. You already have a DoS error if your server let an
unauthenticated client allocate 1G of memory.. :-)

If it grows superlinearly, then yes, a limit is needed at whatever
point the growth becomes problematic, or just at some sane limit (like
what you did, 30k) that prevents getting to the problematic range.

Either way, I agree it can't hurt to place some reasonable limits in
place; I was just wondering if you have some comments on the growth
rate.

> > It would be nice if these could be done without tables. As-is, I'm not
> > really sure the the de-unrolled code is all that much cleaner than the
> > original, but at least it's slightly smaller...
> > 
> 
> if they are calculated inline then the code is even more slow
> but not really smaller (the two tables are 128 bytes)
> and not really cleaner:

Indeed, I was not thinking of generating tables, just wondering if
there's a simple arithmetic expression for them in terms of i...
However I don't see any obvious answer for most of them.

Rich


  reply	other threads:[~2012-09-18 13:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-15  8:12 Rich Felker
2012-09-15 13:53 ` Szabolcs Nagy
2012-09-15 14:05   ` Luca Barbato
2012-09-16  3:35     ` Rich Felker
2012-09-16  3:48       ` Conrad Pankoff
2012-09-16  4:03         ` Gregor Richards
2012-09-16 11:04       ` Luca Barbato
2012-09-16  3:26   ` Rich Felker
2012-09-16 10:31     ` Szabolcs Nagy
2012-09-16 12:39       ` Rich Felker
2012-09-16  3:29   ` Rich Felker
2012-09-16 21:42     ` Szabolcs Nagy
2012-09-17  3:02       ` Rich Felker
2012-09-17  7:35         ` Szabolcs Nagy
2012-09-18 13:56           ` Rich Felker [this message]
2012-09-15 23:09 ` Isaac Dunham
2012-09-16  3:41 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918135658.GJ254@brightrain.aerifal.cx \
    --to=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).