From: Isaac Dunham <idunham@lavabit.com>
To: musl@lists.openwall.com
Subject: Re: Clash between 'netinet/if_ether.h' and 'linux/if_ether.h'
Date: Tue, 9 Oct 2012 16:13:43 -0700 [thread overview]
Message-ID: <20121009161343.7ce4fa5f.idunham@lavabit.com> (raw)
In-Reply-To: <20121008233307.GP254@brightrain.aerifal.cx>
On Mon, 8 Oct 2012 19:33:07 -0400
Rich Felker <dalias@aerifal.cx> wrote:
> On Tue, Oct 09, 2012 at 12:45:17AM +0200, Abdoulaye Walsimou GAYE wrote:
> > Hello,
> > While trying to compile busybox-1.20.2, the following issue raised:
> >
> > CC networking/ifplugd.o
> > In file included from /home/walsimou/embtoolkit.git/sysroot-armel-linux-arm920t/usr/include/net/ethernet.h:10:0,
> > from networking/ifplugd.c:41:
> > /home/walsimou/embtoolkit.git/sysroot-armel-linux-arm920t/usr/include/netinet/if_ether.h:75:8: error: redefinition of 'struct ethhdr'
> > /home/walsimou/embtoolkit.git/sysroot-armel-linux-arm920t/usr/include/linux/if_ether.h:127:8: note: originally defined here
> >
> > Note that uClibc strategy here is to include linux/if_ether.h
>
> It's a bug to be including linux/if_ether.h, and there's no way to
> work around this without depending on kernel headers, which musl will
Patch that does work around it:
-#ifndef _NETINET_IF_ETHER_H
+/* Check for <linux/if_ether.h> - _LINUX_IF_ETHER_H will also work */
+#if !defined(_NETINET_IF_ETHER_H) || !defined(ETH_ALEN)
#define _NETINET_IF_ETHER_H
+#define _LINUX_IF_ETHER_H /* linux/if_ether.h defines the same stuff */
#include <stdint.h>
#include <sys/types.h>
Not really clean, but all that an application can rely on getting from either header can be found in the other:
on my install, the content of linux/if_ether.h is exactly the same except it uses kernel types.
--
Isaac Dunham <idunham@lavabit.com>
next prev parent reply other threads:[~2012-10-09 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 22:45 Abdoulaye Walsimou GAYE
2012-10-08 23:33 ` Rich Felker
2012-10-09 23:13 ` Isaac Dunham [this message]
2012-10-09 23:15 ` Rich Felker
2012-10-10 0:08 ` Isaac Dunham
2012-10-10 20:06 ` Abdoulaye Walsimou GAYE
2012-10-11 0:01 ` Rich Felker
2012-10-11 4:36 ` idunham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009161343.7ce4fa5f.idunham@lavabit.com \
--to=idunham@lavabit.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).