From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/2163 Path: news.gmane.org!not-for-mail From: Rich Felker Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH 1/4] Build system: give ability to install lib/crt*.o files separately Date: Sat, 20 Oct 2012 19:49:48 -0400 Message-ID: <20121020234948.GU254@brightrain.aerifal.cx> References: <1350764145-10305-1-git-send-email-awg@embtoolkit.org> <1350764145-10305-2-git-send-email-awg@embtoolkit.org> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1350777513 21727 80.91.229.3 (20 Oct 2012 23:58:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Oct 2012 23:58:33 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-2164-gllmg-musl=m.gmane.org@lists.openwall.com Sun Oct 21 01:58:41 2012 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1TPiw9-0002N8-Ik for gllmg-musl@plane.gmane.org; Sun, 21 Oct 2012 01:58:37 +0200 Original-Received: (qmail 9400 invoked by uid 550); 20 Oct 2012 23:58:30 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 9392 invoked from network); 20 Oct 2012 23:58:30 -0000 Content-Disposition: inline In-Reply-To: <1350764145-10305-2-git-send-email-awg@embtoolkit.org> User-Agent: Mutt/1.5.21 (2010-09-15) Xref: news.gmane.org gmane.linux.lib.musl.general:2163 Archived-At: On Sat, Oct 20, 2012 at 10:15:42PM +0200, Abdoulaye Walsimou Gaye wrote: > This will allow toolchain build systems using 3-stages gcc build > to not fail at second stage (which needs lib/crt*.o file). Could you explain what you mean? If a gcc for the target exists at this stage, then it should be possible to build the entire libc. If it doesn't exist, then the Makefile will not work to build the start files, even though it would be possible to build them by invoking the assembler directly. I'm not opposed to this patch but I'd like to understand how it helps. > Signed-off-by: Abdoulaye Walsimou Gaye > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile b/Makefile > index 3c55c8f..ee9f14d 100644 > --- a/Makefile > +++ b/Makefile > @@ -139,6 +139,7 @@ install-headers: $(ALL_INCLUDES:include/%=$(DESTDIR)$(includedir)/%) > > install-tools: $(ALL_TOOLS:tools/%=$(DESTDIR)$(bindir)/%) > > +install-startfiles: $(CRT_LIBS:lib/%=$(DESTDIR)$(libdir)/%) If this patch is adopted, this target should be added to .PHONY and I think the duplicate rule under install-libs should be replaced with a dependency on install-startfiles, no? Rich